Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Starter Digital Fingerprinting (DFP) #1903

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Remove Starter Digital Fingerprinting (DFP) #1903

merged 11 commits into from
Oct 22, 2024

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Sep 20, 2024 •
edited
Loading

Description

  • Remove all references to the Starter DFP in docs
  • Remove classes which only exist for the Starter DFP.
  • Remove tests and associated test data for the Starter DFP
  • Remove Starter DFP from CLI

Closes #1715
Closes #1713
Closes #1641

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added breaking Breaking change improvement Improvement to existing functionality labels Sep 20, 2024
@efajardo-nv efajardo-nv marked this pull request as ready for review September 20, 2024 20:49
@efajardo-nv efajardo-nv requested review from a team as code owners September 20, 2024 20:49
@efajardo-nv efajardo-nv self-assigned this Sep 24, 2024
@mdemoret-nv
Copy link
Contributor

Before merging, I want to check if we should keep the time series computations from HAMMAH

@efajardo-nv efajardo-nv requested a review from a team as a code owner October 19, 2024 02:01
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dagardner-nv
Copy link
Contributor

@efajardo-nv Can you do me a favor and remove the line about TrainAEStage in docs/source/extra_info/known_issues.md

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1003ce1 into nv-morpheus:branch-24.10 Oct 22, 2024
10 of 11 checks passed
@dagardner-nv dagardner-nv mentioned this pull request Nov 5, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@efajardo-nv efajardo-nv

Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
3 participants
@efajardo-nv @mdemoret-nv @dagardner-nv